gnvim icon indicating copy to clipboard operation
gnvim copied to clipboard

Wrong version number in tarball

Open Hawk777 opened this issue 5 years ago • 3 comments

I went to the Releases page on Github and downloaded the latest release tarball (0.1.6). After extracting it, in Cargo.toml, the version field is set to 0.1.0.

Hawk777 avatar Jul 29 '20 16:07 Hawk777

Gnvim doesn't use the version in Cargo.toml. Our build script extracts the version number from git tags (on build).

vhakulinen avatar Jul 30 '20 08:07 vhakulinen

git tags

Which don’t exist if you download a tarball. But feel free to close this ticket if you don’t consider the tarballs on your Releases page to be an acceptable way to get package sources.

Hawk777 avatar Jul 30 '20 14:07 Hawk777

This current way has proven to be a problem with others too, so I'll probably adjust my release flow to add the version number into the Cargo.toml file.

vhakulinen avatar Jul 30 '20 15:07 vhakulinen

Gnvim was rewritten from ground up for gtk4, and the current build file doesn't try access git anymore for the version number. If the problem persists, feel free to reopen this issue.

vhakulinen avatar Nov 27 '22 13:11 vhakulinen