clad icon indicating copy to clipboard operation
clad copied to clipboard

Published 20 hours ago • verified publisher icon vgvassilev

Fixes incorrect derivative produced when array is passed to call expression inside a loop

Open ShounakDas101 opened this issue 1 year ago • 2 comments

Added support for passing by reference in a for loop. In VisitArraySubscriptExpr(), for loops , added condition to check if it has reference variable. Fixes issue #441 and #465

ShounakDas101 avatar Apr 25 '23 15:04 ShounakDas101

My understanding is that's probably not the fix we wanted as many tests seem to fail. I have asked @parth-07 to take a look but since that's inactive for quite some time we might just close it. @ShounakDas101 what do you think?

vgvassilev avatar Jul 18 '23 08:07 vgvassilev

@vgvassilev If this process is incorrect then please close it. Recently I started working on both issues. Please let me know what are the errors generated by this PR. In github actions I have seen only 1 file with error and I believe the cause for that is initialisation of variable in the a different block (The block which has pullback function where it is used).

ShounakDas101 avatar Jul 18 '23 10:07 ShounakDas101

The issues that this pull request intended to fix are already fixed in the master.

vgvassilev avatar Jun 19 '24 18:06 vgvassilev