clad icon indicating copy to clipboard operation
clad copied to clipboard

Published 20 hours ago • verified publisher icon vgvassilev

Move `ProcessDiffRequest` responsibility to `DerivativeBuilder`

Open parth-07 opened this issue 2 years ago • 4 comments

parth-07 avatar May 17 '22 09:05 parth-07

Codecov Report

Merging #450 (08961d5) into master (6f98627) will decrease coverage by 0.27%. The diff coverage is 93.96%.

:exclamation: Current head 08961d5 differs from pull request most recent head 33224c8. Consider uploading reports for the commit 33224c8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   92.52%   92.25%   -0.28%     
==========================================
  Files          35       37       +2     
  Lines        5363     5200     -163     
==========================================
- Hits         4962     4797     -165     
- Misses        401      403       +2
Impacted Files Coverage Δ
include/clad/Differentiator/DerivativeBuilder.h 100.00% <ø> (ø)
include/clad/Differentiator/DerivedFnInfo.h 100.00% <ø> (ø)
include/clad/Differentiator/ForwardModeVisitor.h 100.00% <ø> (ø)
include/clad/Differentiator/ReverseModeVisitor.h 98.68% <ø> (ø)
lib/Differentiator/DerivedFnInfo.cpp 100.00% <ø> (ø)
tools/ClangPlugin.h 69.64% <ø> (-4.05%) :arrow_down:
tools/ClangPlugin.cpp 90.90% <61.11%> (+0.10%) :arrow_up:
include/clad/Differentiator/DerivedFnCollector.h 100.00% <100.00%> (ø)
lib/Differentiator/DerivativeBuilder.cpp 100.00% <100.00%> (ø)
lib/Differentiator/DerivedFnCollector.cpp 100.00% <100.00%> (ø)
... and 16 more
Impacted Files Coverage Δ
include/clad/Differentiator/DerivativeBuilder.h 100.00% <ø> (ø)
include/clad/Differentiator/DerivedFnInfo.h 100.00% <ø> (ø)
include/clad/Differentiator/ForwardModeVisitor.h 100.00% <ø> (ø)
include/clad/Differentiator/ReverseModeVisitor.h 98.68% <ø> (ø)
lib/Differentiator/DerivedFnInfo.cpp 100.00% <ø> (ø)
tools/ClangPlugin.h 69.64% <ø> (-4.05%) :arrow_down:
tools/ClangPlugin.cpp 90.90% <61.11%> (+0.10%) :arrow_up:
include/clad/Differentiator/DerivedFnCollector.h 100.00% <100.00%> (ø)
lib/Differentiator/DerivativeBuilder.cpp 100.00% <100.00%> (ø)
lib/Differentiator/DerivedFnCollector.cpp 100.00% <100.00%> (ø)
... and 16 more

codecov[bot] avatar May 17 '22 09:05 codecov[bot]

@parth-07, can you rebase this PR?

vgvassilev avatar May 19 '22 17:05 vgvassilev

@vgvassilev I have rebased the PR.

parth-07 avatar May 19 '22 18:05 parth-07

Can you add more details in the commit message and rebase the PR?

vgvassilev avatar Jun 23 '22 18:06 vgvassilev