vgstation13 Grues should hopefully always force their victims to drop their items now

The code likely errored out because gib() was already calling death(1) so the mob's death was actually getting called twice when a grue would eat someone. Thanks @nervere

:cl:

bugfix: Fixed an issue where a mob's death would happen twice when eaten by a grue. This should also hopefully fix a bug where a victim's items would not always drop when being eaten by a grue.

Mar 07 '24 12:03 boy2mantwicethefam

Good call but have you tested if this fixes it?

Mar 07 '24 14:03 Pastamadness

It works in-game but the bug itself appears to be elusive, it's mentioned pretty often that sometimes it works as it should and sometimes some items still disappear.

Mar 07 '24 14:03 boy2mantwicethefam

guh? what items don't drop?

also, this reverts "grue eating alerts SPS"

Mar 07 '24 16:03 hacker-on-steroids

Random ones, supposedly. I'm gonna try to look into having gib() have an option for dropping items, much like ashing

Mar 07 '24 21:03 boy2mantwicethefam

you could also try replacing the death(1) with a death(0)? i'm really not sure why i put a 1 there in the first place ~and if you do happen to look at gib() try to figure out why sometimes the head vanishes, #34055~ nvm figured it out, https://github.com/vgstation-coders/vgstation13/blob/f5442df32a21ad8c5e3cbc12681b5049e564992b/code/modules/mob/living/carbon/human/death.dm#L14-L16

Mar 07 '24 22:03 hacker-on-steroids

guh? what items don't drop?

also, this reverts "grue eating alerts SPS"

Death shouldn't be getting called twice, there are better ways to make sure an SPS is triggered than that. I don't think this will fix the issue though.

Mar 08 '24 04:03 nervere