vgstation13
vgstation13 copied to clipboard
vgstation-coders
No naked round start
Last roundstart PR: finally uncouples a bunch of things from mind.initial_account so characters don't need a mind to be equipped. Have to totally redo virtual accounts some other way to get this to work.............
What this does
- ckeys are now transferred at the last possible moment (0 NAKEDNESS)
- Changes account creation slightly so that virtual wallets can also be defined as a parameter
- Renames ID member variable
associated_account_numbertoaccount_number - Renames some
create_account()variables tomoney_accountnames to avoid confusion (trust me, it gets confusing) - You get to stare blankly at the splash screen now
Why it's good
- No naked
Changelog
:cl:
- tweak: No naked roundstart
What does this look like to a player now? Does the round just start and we wait at the lobby screen until everything is fully loaded or are we going to face another strange purgatory before we can actually start moving?
What does this look like to a player now? Does the round just start and we wait at the lobby screen until everything is fully loaded or are we going to face another strange purgatory before we can actually start moving?
Splash screen
to think all this happened because someone was upset the department lights took 2 seconds to turn on after roundstart
to think all this happened because someone was upset the department lights took 2 seconds to turn on after roundstart
TEN SECONDS
It'll be nice aesthetically to have the round start in a fully-loaded state.
entirely unatomic also horrible change virtual wallets are what protects your entire bank account from being drained it's ridiculous to remove features because it interferes with a bug you made apparent
Having virtual wallet and station account be separate is a valuable thing that comes up a lot. Like, for example, no less than 24 hours ago I stole all the money out of 3 player PDAs. That didn't hurt them too much because they could just go get more from the ATM, but without virtual wallets I could've taken them for everything they're worth.
Having virtual wallet and station account be separate is a valuable thing that comes up a lot. Like, for example, no less than 24 hours ago I stole all the money out of 3 player PDAs. That didn't hurt them too much because they could just go get more from the ATM, but without virtual wallets I could've taken them for everything they're worth.
I know, before I removed it, I mentioned I would add security preferences to withdrawals from PDAs, but it seems a majority disliked the idea, so I'm no longer doing it
I am not sure why there are downvotes, I undid the changes regarding merging the virtual wallet and bank account together. They will remain separate and keep both their same functionalities
This is one of the least atomic PR’s that isn’t a bunch of new features I’ve ever seen
no-naked is good though
This is one of the least atomic PR’s that isn’t a bunch of new features I’ve ever seen
no-naked is good though
It's actually atomic, but comes with fixes and better code readability. There's no way around this in mind.dm:
/datum/mind
var/datum/money_account/initial_account
var/initial_wallet_funds = 0
And:
/obj/item/weapon/card/id
var/datum/money_account/virtual_wallet = 1 //money! If 0, don't create a wallet. Otherwise create one!
The eyes of both of them were opened, and they knew that they were naked. So they sewed fig leaves together, and made coverings for themselves.
hey if the cargo console computer uses the wallet instead of the bank account to purchase stuff won't it become impossible to order stuff using the budget cards
Nice catch
oh yeah could you make the cargo computer take from the virtual wallet while you're unatomising everything
goddamn i wanna drop a rock in your head's direction sometimes for shit like this
nakedness somehow has stopped happening now so I don't see the necessity of this PR
nakedness somehow has stopped happening now so I don't see the necessity of this PR
It actually still happens but not to yourself. It will get worse with more players
