vgstation13 icon indicating copy to clipboard operation
vgstation13 copied to clipboard

Increases time to self-extinguish

Open west3436 opened this issue 3 years ago • 8 comments

Draft: need to test this later to make sure the values are reasonable.

What this does

Increases the time it takes to extinguish fires. Previously, your character would roll between 8-12 times with 2 ticks between each roll. This update will now make you roll a minimum of 8 times with a maximum depending on how many firestacks are present on you with a 10 tick delay between rolls.

Why it's good

Stopping-dropping-and-rolling should be a last-resort option that carries the downside of continuing to be burned over a longer duration before being extinguished. The ideal method of self-extinguishing a fire should be using an extinguisher or having someone extinguish you before resorting to stopping-dropping-and-rolling as a last resort.

Changelog

:cl:

  • tweak: Increased the time it takes to self-extinguish when you are on fire.

west3436 avatar Oct 05 '22 17:10 west3436

Extinguishing time really should scale with the intensity of the fire or how long you were burning for. You shouldn't have to roll around on the ground for ten seconds because you passed through a single campfire.

gurfan avatar Oct 05 '22 17:10 gurfan

Extinguishing time really should scale with the intensity of the fire or how long you were burning for. You shouldn't have to roll around on the ground for ten seconds because you passed through a single campfire.

This code will make it scale with intensity but not time. Making the intensity increase as you are on fire would be a simple update for a future PR, however.

west3436 avatar Oct 05 '22 17:10 west3436

:+1: There's fire extinguishers everywhere and this would encourage people to make an effort to actually save people on fire

PavelCIA avatar Oct 05 '22 19:10 PavelCIA

increase the damage of fires increase the time to extinguish

Uhh let's just do one at a time

adacovsk avatar Oct 05 '22 22:10 adacovsk

increase the damage of fires increase the time to extinguish

Uhh let's just do one at a time

I am, they're in two separate PRs :^)

west3436 avatar Oct 05 '22 22:10 west3436

I am, they're in two separate PRs :^)

You're pretending that Kurfurst doesn't merge 20 PRs at once. Anyway, I'm not necessarily against this, but buffing fire and nerfing anti-fire might cause some balance issues

adacovsk avatar Oct 05 '22 23:10 adacovsk

Extinguishing time really should scale with the intensity of the fire or how long you were burning for. You shouldn't have to roll around on the ground for ten seconds because you passed through a single campfire.

Maybe campfires shouldn't set you ablaze unless you're covered in a flammable liquid? Humans aren't really flammable and you'd think clothing designed in the 2500s wouldn't ignite so easily.

githubuser4141 avatar Oct 06 '22 22:10 githubuser4141

you'd think clothing designed in the 2500s wouldn't ignite so easily

NT-brand jumpsuits are made in spacechinese sweatshops with bottom of the barrel materials, people die so often that there's a financial incentive to making shit clothing.

Eneocho avatar Oct 07 '22 17:10 Eneocho

Just tested and this is reasonable; it's about 3-4 times as long as the current duration. Even with the effects of #33441 merged, you've got a good 10-20 second window to start the stop-drop-and-roll to get out of the fire without going into crit.

west3436 avatar Oct 09 '22 22:10 west3436

Just tested and this is reasonable; it's about 3-4 times as long as the current duration. Even with the effects of #33441 merged, you've got a good 10-20 second window to start the stop-drop-and-roll to get out of the fire without going into crit.

what if I get ZASd from being locked in a room full of fire, then try to escape

adacovsk avatar Oct 10 '22 14:10 adacovsk

Just tested and this is reasonable; it's about 3-4 times as long as the current duration. Even with the effects of #33441 merged, you've got a good 10-20 second window to start the stop-drop-and-roll to get out of the fire without going into crit.

what if I get ZASd from being locked in a room full of fire, then try to escape

then you will die unless someone rescues you like anyone else trapped in a burning room would

west3436 avatar Oct 10 '22 14:10 west3436

SECONDS multiplies the value by 10, so when you just write SECONDS it's like saying sleep(*10)

Kurfursten avatar Oct 11 '22 16:10 Kurfursten