vgstation13 icon indicating copy to clipboard operation
vgstation13 copied to clipboard

Light cigarettes by shooting them with laser guns, grammar fix

Open smalIboss opened this issue 3 years ago • 12 comments

What this does

you can now shoot at cigarettes to light them. you need to click on the sprite to hit. does this by having cigarettes check if whatever hit them has is_hot(). beam projectiles now have is_hot(), which will return the temperature if the projectile has more than 0 damage. right now you can only shoot at cigarettes to light them. cant light them when theyre on you or someone else yet, which i also want to add. also closes #33310 , single line grammar correction

Why it's good

its realistic

Changelog

:cl:

  • rscadd: Laser weaponry can now light cigarettes from a range.

smalIboss avatar Sep 18 '22 04:09 smalIboss

this is the biggest feature of the year

gurfan avatar Sep 18 '22 07:09 gurfan

give unlit cigs 50% head laser resist? obviously drops to 0 after you get shot and the cig lights up

pedr69 avatar Sep 18 '22 13:09 pedr69

Won't lasers having is hot cause some weird interactions with fuel puddles and plasma? I feel some unforeseen consequences.

Eneocho avatar Sep 18 '22 14:09 Eneocho

Won't lasers having is hot cause some weird interactions with fuel puddles and plasma? I feel some unforeseen consequences.

had this fear too, but from what i understand reading the code, the only way this will interact with other heatable objects is if those objects already have an on_hit trigger that checks for is_hot. i didnt spot this anywhere yet, most objects just use attackby to check for it, so it wont come up. this is why i think itll be hard to add lighting cigarettes on your person without some unforeseen consequences.

give unlit cigs 50% head laser resist? obviously drops to 0 after you get shot and the cig lights up

was thinking about adding some kind of way to light it by shooting someone too. funny idea but a laser would not simply hit your cigarette and block the shot if this was a real life situation at a space station. your face would be hit, including your cigarette. i have no idea how to do that yet but ill look into it.

smalIboss avatar Sep 18 '22 15:09 smalIboss

was thinking about adding some kind of way to light it by shooting someone too. funny idea but a laser would not simply hit your cigarette and block the shot if this was a real life situation at a space station. your face would be hit, including your cigarette.

They're space cigarettes with laser attracting capabilities. Just make it so if you're wearing an unlit cigarette and get shot in the head, the damage gets nulled and the cig gets lit.

Eneocho avatar Sep 18 '22 16:09 Eneocho

They're space cigarettes with laser attracting capabilities.

i literally worked on this games lore and theyre not.

smalIboss avatar Sep 18 '22 16:09 smalIboss

They're space cigarettes with laser attracting capabilities.

i literally worked on this games lore and theyre not.

Bro they're space cigs, you can claim whatever about them. For fucks sake you can use cigarettes as internals.

Eneocho avatar Sep 18 '22 17:09 Eneocho

You really need to give it one of those Zippo-style messages when you light the cigarette. Something like this: https://github.com/vgstation-coders/vgstation13/blob/70591c188f8d54a325d7bd7662bb8ee5665d3406/code/game/objects/items/weapons/cigs_lighters.dm#L286

nervere avatar Sep 18 '22 17:09 nervere

will continue this pr soon

You really need to give it one of those Zippo-style messages when you light the cigarette. Something like this:

https://github.com/vgstation-coders/vgstation13/blob/70591c188f8d54a325d7bd7662bb8ee5665d3406/code/game/objects/items/weapons/cigs_lighters.dm#L286

ive been thinking about it.

smalIboss avatar Sep 18 '22 20:09 smalIboss

The code end looks fine, but it sounds like you wanted to add more so I will wait to merge

Kurfursten avatar Sep 21 '22 21:09 Kurfursten

Will you?

Kurfursten avatar Sep 23 '22 20:09 Kurfursten

Will you?

i didnt forget yet just been busy with not-coding

smalIboss avatar Sep 24 '22 06:09 smalIboss

@Kurfursten i cant come up with anything cool for the flavor text so you can merge this i guess

smalIboss avatar Oct 17 '22 20:10 smalIboss

Distance from shooter

range = 0 [user] draws \the [Proj.shot_from] and shoots straight down, lighting \the [src] at his feet. Damn. range < 3 [user] flicks \the [Proj.shot_from] and lights \the [src] without even looking. Damn! range 3 to 7 [user] closes one eye and blasts \the [src] with a pinpoint [Proj]. Hot damn! 7+ [user] lit \the [src] with blind [Proj] fire!

Kurfursten avatar Oct 17 '22 20:10 Kurfursten

[user] lit \the [src] with blind [Proj] fire!

Add a holy shit at the end. [user] lit \the [src] with blind [Proj] fire! HOLY SHIT!

Eneocho avatar Oct 17 '22 20:10 Eneocho

@smalIboss dead PR?

ShiftyRail avatar Nov 18 '22 08:11 ShiftyRail