vgstation13 icon indicating copy to clipboard operation
vgstation13 copied to clipboard

Change AI's see_invisible from SEE_INVISIBLE_LEVEL_TWO to SEE_INVISIBLE_LEVEL_ONE

Open adacovsk opened this issue 2 years ago • 9 comments

AIs can see everyone that uses invisibility potions, vampires who are hidden by shadows, wizards who jaunt, and cultists who astral journey, and I have no idea why it's set so high. This PR reduces it to level_one so they can at least see infrared

What this does

  • changes turret invisibility to level_one
  • changes see_invisibility for AIEye to level_one

Why it's good

  • Unintended that they can see such mobs
  • Closes #33029

Changelog

:cl:

  • tweak: Changes some invisibility values for AIs

adacovsk avatar Aug 09 '22 15:08 adacovsk

Good PR

wotisjanitor avatar Aug 09 '22 15:08 wotisjanitor

I have no idea why it's set so high

Don't you know? I see people on the security cameras all the time, shit's so high quality you could put it directly on a newscaster wanted article

In other news have you seen this man

Mh3R0oR

WindowsErrors avatar Aug 09 '22 16:08 WindowsErrors

Make it so malf AI can still see level two (something something eldritch code detection).

Eneocho avatar Aug 09 '22 17:08 Eneocho

Good PR

Nevermind it sucks now

wotisjanitor avatar Aug 09 '22 18:08 wotisjanitor

I thought about mentioning

  • how lazy just calling it "AI upgrade" for an upgraded var when it's both functionally and explicitly not a general upgrade but specifically a camera upgrade
  • what a weird implementation it is for a camera upgrade to be applied to the AI when all other camera upgrades are per-camera and already have their own fairly standard method of upgrading

but it's not like it'll get merged anyway

Kammerjunk avatar Aug 10 '22 01:08 Kammerjunk

can you just fix the fucking issue first

gurfan avatar Aug 10 '22 02:08 gurfan

what a weird implementation it is for a camera upgrade to be applied to the AI when all other camera upgrades are per-camera and already have their own fairly standard method of upgrading

Could be an improved image recognition software update.

Eneocho avatar Aug 10 '22 02:08 Eneocho

was he bullied successfully? can i change my emoji?

wotisjanitor avatar Aug 10 '22 17:08 wotisjanitor

was he bullied successfully? can i change my emoji?

Seems like he changed it back to it just fixing the issue.

nervere avatar Aug 14 '22 16:08 nervere

another success for bullying

I'm going to assume the downvotes are people who didn't go back to change their votes because this seems harmless now

Kurfursten avatar Aug 18 '22 03:08 Kurfursten

Except he forgot to change it in the AI's Life() procs so this PR did nothing at all

image

DeityLink avatar Jul 14 '23 17:07 DeityLink