vgstation13 icon indicating copy to clipboard operation
vgstation13 copied to clipboard

Stoplag Update

Open adacovsk opened this issue 2 years ago • 10 comments

inspired by https://github.com/yogstation13/yogstation-2017-/pull/3010

What this does

  • Replaces a round with ceiling
  • Sets a delay of at least one tick in stoplag
  • parameter determines delay, can replace sleeps where they're used for high workload
  • moved stoplag to tick, along with other tick-related macros
  • changed some sleeps into stoplag that shouldn't make any impact
  • will test and compare different things

Why it's good

  • Less lag

:cl:

  • tweak: Made an attempt to reduce some lag

adacovsk avatar Jul 12 '22 14:07 adacovsk

"Hopefully less lag"? Got some before/after numbers? The downdoot is here because this doesn't seem throughly tested by you. Just more code copying...

jwhitak avatar Jul 12 '22 15:07 jwhitak

"Hopefully less lag"? Got some before/after numbers? The downdoot is here because this doesn't seem throughly tested by you. Just more code copying...

I don't have my own server so I can't test it and it can be reverted if it causes problems. Yogstation has been using it for a few years without any issues. tg always has something new

adacovsk avatar Jul 12 '22 15:07 adacovsk

Can't you test it on localhost and make some lag machines for stress testing?

Eneocho avatar Jul 12 '22 17:07 Eneocho

@ThatLing Is it cool if I port this to vg? Thanks

adacovsk avatar Jul 13 '22 02:07 adacovsk

Less lag according to Yog

changed some sleeps into stoplag that shouldn't make any impact

Hopefully less lag

tweak: Made an attempt to reduce some lag

I feel eternal agony

PrimeDSS13 avatar Jul 13 '22 02:07 PrimeDSS13

@adacovsk I just ported it from /tg/

ThatLing avatar Jul 13 '22 08:07 ThatLing

@MrStonedOne is it cool if I port this to vg? Thanks

adacovsk avatar Jul 13 '22 08:07 adacovsk

local coder has absolutely no idea what he is doing

gurfan avatar Jul 13 '22 15:07 gurfan

local coder has absolutely no idea what he is doing

That's every coder.

Eneocho avatar Jul 13 '22 17:07 Eneocho

local coder has absolutely no idea what he is doing

https://github.com/vgstation-coders/vgstation13/pull/15165

adacovsk avatar Jul 13 '22 17:07 adacovsk