vgstation13 icon indicating copy to clipboard operation
vgstation13 copied to clipboard

Weldertank Explosion Snowflakery Is Bad

Open Kurfursten opened this issue 5 years ago • 10 comments

Related to #23661

Instead of welding tanks exploding when you hit them with a lit welder, it should be that one of these two things is true:

  • Anything you hit with a lit welder containing a "lot" of fuel should explode OR
  • Chem heating. Fuel explodes with sev based on quantity when it reaches a certain temperature. Hitting things with welders already warms them up.

Right now if you welder an empty tank (or remote signaller it for that matter) it will still explode. Dumb.

Kurfursten avatar Sep 16 '19 08:09 Kurfursten

You mean like how goon station lets you drag the welding tank onto a lit cigarette, run, and then watch it explode and set the bar on fire?

SGuivenne avatar Sep 16 '19 12:09 SGuivenne

Not sure that lit cigs heat everything on their tile like that, but general idea

Kurfursten avatar Sep 16 '19 13:09 Kurfursten

with option 2: so autoignition temperature for chems and objects (like paper) that can ignite? does oxygen need to be present for ignition? a cigarette won't ignite a welding tank on the same tile but a plasma fire should

incakola avatar Sep 17 '19 06:09 incakola

We do already have a define for AUTOIGNITION_WELDERFUEL which is what is used in determining if a welding tank will explode due to heat. This already occurs -- as in, if you raise a fuel tank above 561.15k (288C) it will explode. But the bad thing is that it happens regardless of whether the tank actually contains fuel.

Instead we should just have fire_act pass heating on to the reagents within (assuming chemheating doesn't already do this)

Kurfursten avatar Sep 17 '19 08:09 Kurfursten

What about the other snowflakery functions they have? This includes but is not limited to -fire makes welding tank explode if fire is on the same tile. Shuttle fire included -shooting a welder fuel tank with things such as bullets and lasers make them explode. This would be a shame to lose -firebirds crashing into welding fuel tanks cause it to explode Additionally, empty welder tanks exploding still makes sense due to fumes and residue likely still being in the tank

Killette2 avatar Sep 18 '19 19:09 Killette2

  1. Should only happen if it has fuel in it, and it should be at a reagent dispenser or perhaps even general reagents level so that anything containing enough fuel should explode in the presence of fire.
  2. Why not shoot anything containing fuel to make it explode? Actually, shooting it with a laser should heat up its contents and detonate it by chemheating (so you could laser a tank of sugar to make caramel!) -- maybe shooting any reagent dispenser with bullets should make it leak its contents splashed onto the floor, and throw sparks. Dynamic welding fire!
  3. Firebirds crashing into any reagent dispenser (incl water tanks, etc.) that contain fuel should explode, I think.

Kurfursten avatar Sep 18 '19 21:09 Kurfursten

Great ideas. Uhh, are tanks procedural now? Are there ways to empty a tank and fill it with something else? For example, hydroponics could make bulk batches of mutagen or fertilizer instead of needing to ask for bluespace beakers.

I remember when all the xenobio water tanks were full of pepper spray.

ghost avatar Sep 19 '19 02:09 ghost

Procedural in what way?

And yes - removing reagents from a tank is naturally the easy part. Of reagent dispensers only cauldrons currently let you pour reagents back in (uses intent), but we should expand that to all dispensers [fuel tank, water tank, corn oil tank, ethanol tank, etc.].

Kurfursten avatar Sep 19 '19 05:09 Kurfursten

hey i was thinking about this if someone drinks a bunch of welding fuel would they explode if hit with a lit welder? like i mean a LOT

Tokanova avatar Dec 20 '19 03:12 Tokanova

fixed by #34103

SECBATON-GRIFFON avatar Apr 25 '24 03:04 SECBATON-GRIFFON