Vincent Geddes

Results 21 comments of Vincent Geddes

We haven't really been affected by this off-by-one issue while developing our light client (or we just worked around it). The proposed change may affect how our light client detects...

I'm happy with this change too. It makes sense for me and would allow us to improve some of the code in our off-chain relayers. As the relationship between block-height,...

Should not be a problem for our light client, I think.

There's a similar issue when `chain_spec_command` command is used for the relay chain, that causes genesis customizations to be discarded. I think they are directly related and touch the same...

Just an update from the Snowfork side, we're mostly debating this issue on the Polkadot Bridges group on element: https://matrix.to/#/#bridges:web3.foundation.

> 5\. check that leaves aren't ever 32 bytes to avoid ambiguity with nodes, also suggested by @AlistairStewart. > MMR leaves are (currently) 232 bytes, so this is easily guaranteed....

> Of course this may change, as I think there is nothing in the protocol that prevents head_data from just containing a 32-byte parent hash, in which case such a...

@Lederstrumpf @acatangiu Can we revert the optimization in https://github.com/paritytech/substrate/pull/12857? Unfortunately it introduced a security vulnerability, which we only discovered this week. Apologies for the time everyone spent debating this optimization....

@Lederstrumpf as per our discussion, here's a high-level overview of why leaf indices are important for our validator subsampling protocol, and how our optimization tripped us up. The offchain relayer...

Ack, yes, I'll publish `ethabi-decode` and `milagro-bls` this week. Thanks for the reminder.