gue icon indicating copy to clipboard operation
gue copied to clipboard

Trying to install 4.1.0 fails due to otel deps

Open agis opened this issue 1 year ago • 9 comments

Apparently otel removed some of their previously-working import paths (https://github.com/open-telemetry/opentelemetry-go/issues/2897), so we might need to bump their versions in the v4 branch.

$ go get -u github.com/vgarvardt/gue/v4
go: github.com/vgarvardt/gue/v4 imports
	go.opentelemetry.io/otel/metric/instrument: cannot find module providing package go.opentelemetry.io/otel/metric/instrument
go: github.com/vgarvardt/gue/v4 imports
	go.opentelemetry.io/otel/metric/instrument/syncint64: cannot find module providing package go.opentelemetry.io/otel/metric/instrument/syncint64
go: github.com/vgarvardt/gue/v4 imports
	go.opentelemetry.io/otel/metric/unit: cannot find module providing package go.opentelemetry.io/otel/metric/unit

agis avatar Jul 04 '24 14:07 agis

Starting from v1.25.0 OTel requires go 1.21 and gue is currently pinned to go 1.20. I'll bump min required version to 1.21 since 1.20 reached end of support already.

vgarvardt avatar Jul 04 '24 15:07 vgarvardt

pls check if https://github.com/vgarvardt/gue/releases/tag/v5.7.0 solves your problem

PS GH closed the issue automatically after the linked PR was merged

vgarvardt avatar Jul 04 '24 15:07 vgarvardt

Can you backport this to v4 so that I can give it a try? Thanks!

On Thu, Jul 4, 2024, 18:47 Vladimir Garvardt @.***> wrote:

pls check if https://github.com/vgarvardt/gue/releases/tag/v5.7.0 solves your problem

— Reply to this email directly, view it on GitHub https://github.com/vgarvardt/gue/issues/287#issuecomment-2209264508, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGJ6WGAWYMNOHSH2K6C6VTZKVVANAVCNFSM6AAAAABKLVQLUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBZGI3DINJQHA . You are receiving this because you authored the thread.Message ID: @.***>

agis avatar Jul 04 '24 17:07 agis

oh, v4 - this version is not support anymore, most likely you'd need to create your fork

vgarvardt avatar Jul 04 '24 17:07 vgarvardt

Would you be open to a PR backporting this in v4, so that we avoid forking?

agis avatar Jul 05 '24 10:07 agis

I do not even have a separate branch with v4, will try to create one later today from the commit before switched to v5

vgarvardt avatar Jul 05 '24 10:07 vgarvardt

Thanks a lot!

agis avatar Jul 05 '24 13:07 agis

If I can do anything to help, please let me know.

agis avatar Jul 16 '24 07:07 agis

just merged https://github.com/vgarvardt/gue/pull/290 to newly created v4 branch. Pls check if it solves your problem. If all good - I'll release 4.2.0

vgarvardt avatar Jul 17 '24 21:07 vgarvardt

Thanks, closing this as it's resolved.

agis avatar Sep 03 '24 12:09 agis