Added Zend 3 support

[goldforg]

Added Zend 3 support to the library and benefit that in older migration scripts it is possible to use getServiceLocator method.

[goldforg]

Hi Vladimir,

Do I need to create CHANGELOG.md or is there one you did not commit yet?

Sincerely, Rolands

piektd., 2022. g. 28. janv., plkst. 16:56 — lietotājs Vladimir Garvardt (< @.***>) rakstīja:

@.**** commented on this pull request.

Thank you! Will check the rest later today or tomorrow.

In README.md https://github.com/vgarvardt/ZfSimpleMigrations/pull/21#discussion_r794628243 :

@@ -2,6 +2,13 @@

Simple Migrations for Zend Framework 2. Project originally based on ZendDbMigrations but module author did not response for issues and pull-requests so fork became independent project.

+## Added Zend 3 Support 28.01.2022

Please extract this to the new CHANGELOG.md under the ## Unreleased - will tag it with the version as soon as it will be ready for the release

In src/ZfSimpleMigrations/Library/AbstractMigration.php https://github.com/vgarvardt/ZfSimpleMigrations/pull/21#discussion_r794629356 :

abstract class AbstractMigration implements MigrationInterface

{

 private $sql = [];

 private $metadata;

 private $writer;

• protected $serviceLocator;

⬇️ Suggested change

• protected $serviceLocator;

• /** @var ServiceLocatorInterface */

• protected $serviceLocator;

— Reply to this email directly, view it on GitHub https://github.com/vgarvardt/ZfSimpleMigrations/pull/21#pullrequestreview-866329980, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXX5XDJHEJ26TOYZOTOPE3UYK4B7ANCNFSM5NA66ELA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

[vgarvardt]

@goldforg create it please

[goldforg]

Hi Vladimir,

I added CHANGELOG.md to your library under ## unreleased.

Sincerely, Rolands

piektd., 2022. g. 28. janv., plkst. 18:09 — lietotājs Vladimir Garvardt (< @.***>) rakstīja:

@goldforg https://github.com/goldforg create it please

— Reply to this email directly, view it on GitHub https://github.com/vgarvardt/ZfSimpleMigrations/pull/21#issuecomment-1024429172, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXX5XG2R2PTISL2WQ44ZHDUYLEVZANCNFSM5NA66ELA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

[vgarvardt]

Tests are not passing - I think something in composer needs to be updated. Currently it is locked to zf2.