ViMusic
ViMusic copied to clipboard
vfsfitvnm
Remove "loop none" option
Currently, the playback has 3 loop options:
- Loop none: when the queue ends, the playback ends as well
- Loop all: when the queue ends, the playback re-starts from the first song in the queue
- Loop one: when the playing song ends, it is restarted
However, I think the "loop none" is useless: in which scenario its behavior is desiderable? Personally, I always make sure it's not selected, because I'd rather listen to the same songs than having silence.
Preview:
https://user-images.githubusercontent.com/46219656/188190769-06630fb1-e258-43a2-a0d9-aee8ec1afa6d.mp4
What do you think?
Hmm I personally do not have any use to it as well, but I think maybe some people might sleep while music is playing and so they'd want their queue to eventually end. You can still go with your idea (I like the icon and it gives it something unique relative to other apps) but you might have to consider adding a sleep timer which cuts the music after a certain amount of time.
Obviously someone who has a genuine use case for it is more fit to speak than me but since nobody commented yet I thought I'd give my opinion.
Regarding the icon, this is the alternative:
https://user-images.githubusercontent.com/46219656/188282467-cf62d3e5-2af3-40aa-9b39-25825086128a.mp4
Can you add a "Play until end of Playlist" option to the sleep-timer, because I use "loop none" quite often.
If I hear a playlist and then want to hear sth. other. When I would append the other playlist, Shuffle would shuffle everything, jot just the second playlist.
With the option I notive when the playlist is heared. Then I can play the next.
You can simply enqueue the playlist you plan to listen next, so you don't have to worry about it at all (even if the "loop none" option was still present) :smile:
@Jak2k In which situations do you use the loop none?
I personally would use (and have used) "loop none" most of the time. Sometimes I just want to hear one song to motivate myself e.g. for starting to clean teeth. With "loop none", playback would stop after the song ends, but I could finish cleaning teeth and meanwhile think about the song. But now the problem is that the song will repeat, so I don't have this short, but nice silent moment afterwards anymore. Also, songs often have different moods at the beginning and at the end. So when I want to hear one only once, I have to stop playback really quickly after it has ended. Otherwise only the first 2 seconds of the repeated song could through me out of the "end mood" which is really annoying.
I agree with @thornySoap, sometimes you just want to listen to a single song/album/playlist. All music players that I know of have 'loop none' set by default, and "I don't use it so neither do you" is probably not the best excuse for removing a feature like that. Likely 45235ac won't take any work to rollback.
Just now it happened again. Please don't ask why, but I just heard the complete soundtrack of a Star Wars film. The music of the credits ended, I was hanging around in memories. But then suddenly the opening fanfare blew the mood completely away, because I was not fast enough to stop it. That is very annoying
My point was it's very annoying to cycle through three loop options: I proposed to remove the one I thought was used the least, nobody complained so I proceeded. All I care is the ability to set and unset the "loop one" option with only one tap - and I can already tell you the three loop option cycle won't come back.
However, I understand your points. I see two solutions:
- Remove the "loop all" option instead (yet it would cause similar complains)
- Long press to set the "loop none" option (it would be hard to discover?)
Of course there's a third option, that is adding an option ion in the settings to disable the automatic queue looping. But, to do so, I must understand how much frequently a user changes the loop mode from "loop all" and "loop none". Is that a user preference, or does it depends on the playlist?
- Remove the "loop all" option instead (yet it would cause similar complains)
- Long press to set the "loop none" option (it would be hard to discover?)
- Yeah, as I previously said those three loop options are offered by all music players, so removing one of them will eventually lead to more complains
- It could work, maybe a double tap (to disable looping sort to say) might be easier to discover since it's what people are already doing to cycle between the options. But again, the way it was previously is how new users will expect it to work, so be ready to hear that question a lot.
Is that a user preference, or does it depends on the playlist?
Personally, I use 'loop none' 90% of the time (not necessarily depending on the playlist), but I don't like the idea of digging through the settings for that 10%
Maybe put the loop all/none option here?
That's a good placement (the "loop all/none" involves the whole queue rather than a single song), however I'm not sure about the icon (even though a simple text would be fine as well) and what should happen when the "loop one" option is enabled as well. What loop mode has the highest importance? Does swapping the queue loop mode also reset the single track loop?
I would say loop one has a higher priority than loop all and changing one of them doesn't change the other one, so accidently tapping it wouldn't be annoying
What do you think?
https://user-images.githubusercontent.com/46219656/196216531-ef24aa56-f324-46a4-a3c3-9b9a56a7043d.mp4
I like it really much too. But couldn't "loop none" be missunderstood since a single song would loop if "loop one" is checked? Maybe "don't loop" would be more concise
Hmm, I could either disable that button when "loop one" in enabled (the user has to unset the "loop one" first, but this is a thing he would have done anyway to make the "loop all/none" option take effect) or find another name. "Don't loop" refers to an action rather than a state, so it may be confusing, either "loop disabled"/"loop enabled" or "queue loop off"/"queue loop on" sounds better
Implemented. I opted for the "queue loop off"/"queue loop on" thing as temporary (?) solution
this is the worst idea you ever had
You haven't really read the thread, have you?
Implemented. I opted for the "queue loop off"/"queue loop on" thing as temporary (?) solution
Honestly, We are loving it. Like sleep timer is there, Still I don't need it, Cause I don't know when I'll sleep, And whenever I predict my time, And They stop in middle, (Like I keep my phone far from my hand reach, I use headsets.) So Loop none AKA Queue loop off is just great. Maybe it's about personal preferences.