ViMusic icon indicating copy to clipboard operation
ViMusic copied to clipboard

Are artists supposed to show all of their music?

Open emkay5771 opened this issue 2 years ago • 1 comments

Steps to reproduce the bug

  1. search for artist
  2. open artist page

Expected behavior

Show albums, as well as bio for artist.

Actual behavior

Just shows bio... Clicking shuffle seems to work though

Screenshots/Screen recordings

No response

Logs

No response

ViMusic version

0.2.1

Android version

Android 13

Additional information

No response

emkay5771 avatar Jul 22 '22 07:07 emkay5771

Nope, I didn't implement that part yet (I'll mark this as enhancement). The artist page only shows their songs you already listened to (https://github.com/vfsfitvnm/ViMusic/blob/master/fastlane/metadata/android/en-US/images/phoneScreenshots/4.jpg)

vfsfitvnm avatar Jul 22 '22 08:07 vfsfitvnm

Hi, I have seen in #107 that you said that you couldn't implement this, is it still the case? Screenshot_20220919-194100_Debug Here is my take on it, I did not yet implement the database with it, I'm still trying to figure out how does this works with List. You can find the code here if you are interested !

Malopieds avatar Sep 19 '22 17:09 Malopieds

@Malopieds Thanks, this is much appreciated!

vfsfitvnm avatar Sep 20 '22 16:09 vfsfitvnm

Implemented

vfsfitvnm avatar Oct 03 '22 17:10 vfsfitvnm