gitpunch icon indicating copy to clipboard operation
gitpunch copied to clipboard

Too fast emails?

Open AlexWayfer opened this issue 6 years ago • 8 comments

Hello!

Some releases emailed too fast, I think, and emails have no release description.

Examples:

Babel

3:21 AM

image

11:09 AM

screenshot-inbox google com-2018 05 15-11-34-01

Autoprefixer (May 13)

11:20 AM

image

4:12 PM

image

AlexWayfer avatar May 15 '18 08:05 AlexWayfer

so this is what Sibbell calls realtime, interesting

i can add a checkbox to let you control if you wanna wait for release description or you want email ASAP.

i probably cannot determine automatically if release description will follow, because some repos simply don't have release descriptions at all, e.g. https://github.com/angular/angular/releases

vfeskov avatar May 15 '18 09:05 vfeskov

i probably cannot determine automatically if release description will follow, because some repos simply don't have release descriptions at all, e.g. https://github.com/angular/angular/releases

Yes, I know.

i can add a checkbox to let you control if you wanna wait for release description or you want email ASAP.

Good thought. I think, there can be delay for 30 minutes or even 2 hours. Maybe some delay by default.

Real-time is cool, but I'm not sure that this is better than email this release description.

AlexWayfer avatar May 15 '18 09:05 AlexWayfer

some people do want the emails ASAP tho, e.g. #13

vfeskov avatar May 15 '18 09:05 vfeskov

some people do want the emails ASAP tho, e.g. #13

They can enable real-time, I'm talking just about default. But as you wish.

AlexWayfer avatar May 15 '18 09:05 AlexWayfer

+1 from me on this one, having a setting for it to wait for the description would be very useful :+1:

Jacalz avatar May 24 '18 15:05 Jacalz

i probably cannot determine automatically if release description will follow, because some repos simply don't have release descriptions at all, e.g. https://github.com/angular/angular/releases

This means you can check this. So if a repository doesn't have at least one release with a release description, then you can send the email instantly even if this option is enabled. If it does have at least one release with a release description then you can probably use a delay as previously mentioned if this option is enabled.

Also extracting details form the repository's CHANGELOG.md could be useful in this case. For example: https://github.com/angular/angular/blob/master/CHANGELOG.md

kireerik avatar Jun 10 '18 14:06 kireerik

Also extracting details form the repository's CHANGELOG.md could be useful in this case. For example: https://github.com/angular/angular/blob/master/CHANGELOG.md

This is my dream for service like GitPunch, but I think it's very difficult (too many formats, too many regexps).

AlexWayfer avatar Jun 10 '18 15:06 AlexWayfer

A simple way would be to just have an option to delay the emails by a set amount or something...

Jacalz avatar Jul 04 '18 05:07 Jacalz