Maxim Vezenov

Results 33 comments of Maxim Vezenov

LGTM then. I want to leave for @guipublic or @kevaundray to also take a look though as it is a bigger PR.

@jfecher What do we think about using `as_slice()` for slice literals rather than `&[]`. Do we think that syntax will be confusing for users with us not supporting immutable references?

I get to this point in #5865 if we do a copy outside the loop and read the copy in the loop: ``` After Array Set Optimizations: brillig fn main...

> because the frontend doesn't have access to the standard library, it panicked. What I did is to only coerce array to slice if that builtin method actually exists (if...

> and I _think_ it won't be picked up implicitly because it's a trait impl function. It is a trait impl function. You will probably have to do something like...

> I think this won't work either since we prevent impls on primitive types unless it's in the stdlib Ah yes you are correct. Apologies for steering you the wrong...

> What I did is to only coerce array to slice if that builtin method actually exists (if the standard library is defined). That's probably not ideal... I guess this...

This should be ready again for the original simple test cases. I will have follow-ups to enable the use case issues for turbofish listed in the original post of https://github.com/noir-lang/noir/issues/4710....

> LGTM, lets add some formatter tests for completeness. It looks like the tests you adding are failing. I will update them but we did have some other strange bugs...

> Not gonna try and commit at the same time as you but copying the trait impls from the other test should fix it. Trying to wrap up a separate...