Slava Knyazev

Results 133 comments of Slava Knyazev

What is this curl_multi_exec version you speak of?

After more testing. What I did is definitely not merge-able as is. On some systems, handling a failed cURL is more expensive than downloading whatever.

One would wonder why somebody would put those into a href... Should be corrected regardless.

I'm musing with the idea of parsing properly-encoded hrefs, letting cURL handle the weirdness and encode it all right before inserting it.

By lack of easier implementation, an `img_index` function will be called from within the `scan_url` function after failing the header check if the option is enabled.

Personal objective: Going to try to do it over the weekend

I have misjudged the extent of the effort. This opens it's own can of worms. 1. Scan `href`s _and_ `img`s 2. Identifying images 3. Keeping track of context This is...

This is an interesting case of which I was not aware. [This line](https://github.com/knyzorg/Sitemap-Generator-Crawler/blob/c1e19798703b6aaf5ba48021cfd042e921c10436/sitemap.php#L272) currently uses the parent url to resolve relative urls. A simple regex to attempt to extract the...

Where are you running it to get colour support? I could never manage the standard cmd.exe to pick them up, so that is surprising to me. I don't remember why...

This is definitely a bad behavior. I suspect the double `#` are at fault somehow.