subby icon indicating copy to clipboard operation
subby copied to clipboard

Unnecessary new line

Open varyg1001 opened this issue 2 years ago • 2 comments

I bump into this issue. 3rd new line , double hyphen and unnecessary hyphen.

Original:

1
00:05:26,800 --> 00:05:31,200
- Öhm... Bocsánat... Mr.Teufel...
de a...   <i>- Mi a baj, Safranek?!</i>

"Fixed":

1
00:05:26,800 --> 00:05:31,200
- - Öhm... Bocsánat... Mr.
- Teufel...
de a... <i>- Mi a baj, Safranek?!</i>

varyg1001 avatar Nov 16 '23 15:11 varyg1001

This is a tough one. Some sources, particularly Amazon often have subtitles where there is no space after a period, so this fix is appropriate there. Most of the fixes were tested with English, so languages where no space after a dot is ever correct were not taken into account. I'll see what can be done, might add an exception for Mr. and Ms. as a band-aid.

vevv avatar Nov 17 '23 19:11 vevv

I added an exception from breaking for Mr./Ms./Mrs. Leaving the issue open as this can still be an issue with other phrases in non-English languages. https://github.com/vevv/subby/commit/a4c4503da6f07ab0e472fa511e8fb545a31d0bd5

vevv avatar Nov 22 '23 12:11 vevv