Hervé Donner

Results 18 comments of Hervé Donner

Just wanted to thank you all as well for your work, very nice tool! I just opened a [PR](https://github.com/mkalkbrenner/search_api_solr/pull/34) to integrate it in search_api_solr 8.x-3.x which make the whole travis...

Line 339 is trying to parse the "tpa_breakpoint" header but it doesn't exist. So I added this manually which worked but I have no clue if this value is ok...

@Plasmatree It's there in the description. Thanks a lot ;)

Hi @Plasmatree The PID scaling may very well be 10x for roll and pitch as the values I put there are quite similar to many people and it does fly...

Thanks @gingapa ! It doesn't fix it completely (the borders before the chevrons are missing) but is is much better. Note that this issue only seems to appear on an...

This works nicely but as discussed yesterday, we should provide test in the ui_patterns PR. So Antonio will more likely merge the PR.

+1 on this! By looking at the code, it looks like this behavior was done on purpose. Not sure if that's the case or why this would be desirable. So...

+1 on this! Thanks @kp77 this is IMO the proper fix.

It seems there was already a PR that attemps to fix it https://github.com/nuvoleweb/ui_patterns/pull/327 But that one is not OK IMO as `$this->root` is used in 2 places: 1. [LibraryPattern.php#L81](https://github.com/nuvoleweb/ui_patterns/blob/8.x-1.x/modules/ui_patterns_library/src/Plugin/UiPatterns/Pattern/LibraryPattern.php#L81) 2....