nebula icon indicating copy to clipboard operation
nebula copied to clipboard

Feature/pattern expression ref local variable

Open Shylock-Hg opened this issue 2 years ago • 1 comments

What type of PR is this?

  • [ ] bug
  • [x] feature
  • [ ] enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Support pattern expression reference local defined variable, implement this by filter path in list(the result of pattern expressioin)

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • [ ] Unit test(positive and negative cases)
  • [ ] Function test
  • [ ] Performance test
  • [ ] N/A

Affects:

  • [ ] Documentation affected (Please add the label if documentation needs to be modified.)
  • [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • [ ] Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

Shylock-Hg avatar Aug 09 '22 01:08 Shylock-Hg

Codecov Report

Merging #4498 (933396d) into master (b20964a) will increase coverage by 0.16%. The diff coverage is 83.22%.

@@            Coverage Diff             @@
##           master    #4498      +/-   ##
==========================================
+ Coverage   84.56%   84.72%   +0.16%     
==========================================
  Files        1344     1348       +4     
  Lines      134121   134355     +234     
==========================================
+ Hits       113414   113834     +420     
+ Misses      20707    20521     -186     
Impacted Files Coverage Δ
src/graph/executor/StorageAccessExecutor.h 62.22% <ø> (-2.23%) :arrow_down:
src/graph/executor/query/AppendVerticesExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/GetEdgesExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/GetNeighborsExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/GetVerticesExecutor.h 100.00% <ø> (ø)
src/graph/service/PermissionCheck.cpp 81.63% <ø> (+0.38%) :arrow_up:
src/graph/validator/FetchEdgesValidator.h 100.00% <ø> (ø)
.../graph/validator/test/GetSubgraphValidatorTest.cpp 100.00% <ø> (ø)
src/graph/visitor/RewriteSymExprVisitor.cpp 26.33% <0.00%> (+0.11%) :arrow_up:
src/meta/processors/job/BalanceJobExecutor.cpp 66.66% <ø> (+1.51%) :arrow_up:
... and 92 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 09 '22 10:08 codecov-commenter