nebula-go
nebula-go copied to clipboard
some invalid implement in session pool
I find some invalid implement in session pool, could you please take a look at them and I am willing to fix them when they are really invalid.
- why not use the ssl config in session pool config when open a new connection? and it seems that ssl config in session pool makes no use, it this right? https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L301
- it seems this session will remain in active session queue, is this right? https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L118 https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L124 https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L129
- it seems that connection is not closed when miss error after open, is it right? https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L308 https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L316 https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L320 https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L340
Wow, amazing @lee-qiu !!!! cc @Aiee
Hello @lee-qiu,
I have checked the issues you mentioned and it seems they are all valid. It would be great if you are willing to fix these!
Hello @lee-qiu,
I have checked the issues you mentioned and it seems they are all valid. It would be great if you are willing to fix these!
sure, I will fix them in next few days.
@lee-qiu how about fixing this in October for HACKTOBERFEST
?