nebula-go icon indicating copy to clipboard operation
nebula-go copied to clipboard

some invalid implement in session pool

Open lee-qiu opened this issue 2 years ago • 4 comments

I find some invalid implement in session pool, could you please take a look at them and I am willing to fix them when they are really invalid.

  1. why not use the ssl config in session pool config when open a new connection? and it seems that ssl config in session pool makes no use, it this right? https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L301
  2. it seems this session will remain in active session queue, is this right? https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L118 https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L124 https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L129
  3. it seems that connection is not closed when miss error after open, is it right? https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L308 https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L316 https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L320 https://github.com/vesoft-inc/nebula-go/blob/f38f53c8925434804fb7af92bffc25988110bb84/session_pool.go#L340

lee-qiu avatar Jan 09 '23 04:01 lee-qiu

Wow, amazing @lee-qiu !!!! cc @Aiee

wey-gu avatar Jan 09 '23 05:01 wey-gu

Hello @lee-qiu,

I have checked the issues you mentioned and it seems they are all valid. It would be great if you are willing to fix these!

Aiee avatar Jan 11 '23 09:01 Aiee

Hello @lee-qiu,

I have checked the issues you mentioned and it seems they are all valid. It would be great if you are willing to fix these!

sure, I will fix them in next few days.

lee-qiu avatar Jan 12 '23 05:01 lee-qiu

@lee-qiu how about fixing this in October for HACKTOBERFEST ?

wey-gu avatar Sep 25 '23 11:09 wey-gu