nebula-docker-compose icon indicating copy to clipboard operation
nebula-docker-compose copied to clipboard

Enhance version

Open HarrisChu opened this issue 3 years ago • 5 comments

we could define version environment, and then could launch different version by using if compatible

NEBULA_VERSION=v3.0.1 docker-compose up -d

HarrisChu avatar Mar 16 '22 03:03 HarrisChu

BTW v3 is the latest version for v3.x. i.e. it's same with v3.0.1 now. maybe we could just create a v3 branch

HarrisChu avatar Mar 16 '22 03:03 HarrisChu

This will significantly simplify the workflow for both maintainer/doc-maintainer and users, if no structure change of the docker- compose file, branch even won't be needed, like you mentioned, branching based on major version will be sufficient

wey-gu avatar Mar 17 '22 02:03 wey-gu

hold on

nebula-console is not consistent with nebula. i.e. nebula is v3.0.2 but nebula-console won't release v3.0.2.

HarrisChu avatar Mar 30 '22 02:03 HarrisChu

hold on

nebula-console is not consistent with nebula. i.e. nebula is v3.0.2 but nebula-console won't release v3.0.2.

how about this, if the variable is with bash compatibility.

  graphd2:
    image: vesoft/nebula-graphd:${NEBULA_VERSION}
    environment:
      USER: root
...
  console:
-    image: vesoft/nebula-console:${NEBULA_VERSION}
+    image: vesoft/nebula-console:${NEBULA_VERSION::2}
    entrypoint: ""
    command: 
      - sh
$ export NEBULA_VERSION=v3.0.1
$ echo ${NEBULA_VERSION::2}
v3

wey-gu avatar Mar 31 '22 05:03 wey-gu

seems it's ok

HarrisChu avatar Mar 31 '22 06:03 HarrisChu

It's so long. I'll close it and reopen if necessary.

Sophie-Xie avatar Apr 19 '23 03:04 Sophie-Xie