hippie
hippie copied to clipboard
Feature request: Make jar function from request accessible
Hi, Could you please make the jar function from request accessible? https://github.com/request/request#requestjar With this function it would be possible to create multiple cookie jars. Thanks, Daniel
makes sense. wanna try to tackle it?
maybe we can simply yield the request
object:
hippie().configure((request) => {
const jar = request.jar();
request.defaults({ jar });
return request;
});
does this make sense? it also introduces a nice side effect which will enable people to replace the request
module with something that has the same API.
Hey @vesln I tried my best but I didn't get it to work... I rewrote my mocha tests to work around this issue. Sorry that I was not able to contribute to your amazing project. Keep up the good work.
@chdanielmueller no worries! If there is anything I can do to help you implement it, please let me know!
@vesln If you get the time to implement this by yourself it would be cool. It's quite a workaround which I am using at the moment.
I will add it to my queue.
@CacheControl would you be interested in giving this a try?
@vesln I'm currently in the middle of a couple projects and don't have much bandwidth, but I'll add it to my queue as well