django-rest-framework-datatables-editor icon indicating copy to clipboard operation
django-rest-framework-datatables-editor copied to clipboard

Fix for array param

Open ruslankrivoshein opened this issue 6 years ago • 2 comments

I don't know how clumsy this method is, but it helps me in the next case:

{
  "action": "edit",
  "data[1][title]": "title",
  "data[1][files][]": 1,
  "data[1][files][]": 2,
  "data[1][files][]": 3
}

Existing tests pass successfully, but it's useful to cover the fix case as well.

ruslankrivoshein avatar Nov 06 '19 07:11 ruslankrivoshein

Codecov Report

Merging #5 into master will decrease coverage by 0.37%. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage     100%   99.62%   -0.38%     
==========================================
  Files           4        4              
  Lines         266      270       +4     
==========================================
+ Hits          266      269       +3     
- Misses          0        1       +1
Impacted Files Coverage Δ
rest_framework_datatables_editor/viewsets.py 98.24% <80%> (-1.76%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8920b87...9d22304. Read the comment docs.

codecov-io avatar Nov 06 '19 07:11 codecov-io

I don't know how clumsy this method is, but it helps me in the next case:

{
  "action": "edit",
  "data[1][title]": "title",
  "data[1][files][]": 1,
  "data[1][files][]": 2,
  "data[1][files][]": 3
}

Existing tests pass successfully, but it's useful to cover the fix case as well.

Hi @ruslankrivoshein!. Thank you for your contribution! Could you rebase the PR to the latest version and add tests for that case?

vertliba avatar May 17 '20 10:05 vertliba