VerticaPy PC Algorithm (#368)

Sep 28 '22 05:09 zacandcheese

All committers have signed the CLA.

Sep 28 '22 05:09 CLAassistant

@zacandcheese it seems the tests are not passing. Can you please check why? @afard Can you please review the code? @ansleis Can you please review the description of the new features?

Oct 03 '22 10:10 oualib

I will try to do it by the end of the week.

Oct 03 '22 14:10 afard

Sorry, I closed the PR by mistake!

Oct 03 '22 14:10 afard

@afard any news on this one?

Same for the @roypaulin PR. The tests for Python 3.8 are not working. Idk why...

Oct 10 '22 15:10 oualib

Unfortunately, I was busy last week. Hopefully, I'll review it this week. I'll also investigate the strange failures on Python 3.8.

Oct 10 '22 17:10 afard

@oualib, I think the tests for Python 3.8 fail because the default version of matplotlib on 3.8 has changed from 3.5.3 to 3.6.1. Apparently, many of our tests rely on the internal structures of matplotlib that can be frequently changed between their versions. Can you please look at the failed tests and improve them?

Oct 10 '22 18:10 afard

The failing tests on Python 3.8 have been addressed on master. Therefore, updating this branch with master will make the tests pass.

Oct 21 '22 00:10 afard

@zacandcheese you still have errors in your unit tests, can you please have a look?

Dec 05 '22 19:12 oualib

@afard did you have time to read again entirely the PR and Zac comments?

Dec 05 '22 19:12 oualib

This PR needs an entire review. We need to adapt the code to the new architecture. @zacandcheese if you want we can work together on this.

Feb 15 '23 02:02 oualib