tokamak icon indicating copy to clipboard operation
tokamak copied to clipboard

document which packages are obsoleted by tokamak

Open flying-sheep opened this issue 8 years ago • 10 comments

so i found out i can disable

  • language-rust
  • terminal-plus
  • build-cargo

but not

  • linter-rust

by trial and error. it would be nice to have this on the webpage or readme

flying-sheep avatar Apr 13 '16 07:04 flying-sheep

Can you please clarify this with what did you see as error? Currently I had disabled linter-rust for example and it doesn't do linting?

Probably you don't want to see the statusbar at the bottom after disabling linter-rust right? If it is like that linter is a atom plugin that serves as a plugin base for linting multiple languages with itself. First you can disable linter-rust then linter maybe? This way can be your solution.

vertexclique avatar Apr 15 '16 18:04 vertexclique

I think the question:

Which other rust packages are redundant with tokamak and which can be used complementary?

At least that is what I was wondering too. So a short Statement like "you might want to combine this package with X, but you won't need Y" would help because other people might be wondering which packages they need.

colin-kiegel avatar Apr 15 '16 20:04 colin-kiegel

Which other rust packages are redundant with tokamak and which can be used complementary?

exactly. tokamak includes a rust grammar, so also installing language-rust is redundant and you end up with two selectable rust grammars.

so i would like tokamak to list packages that you can disable without losing functionality after installing tokamak

flying-sheep avatar Apr 16 '16 13:04 flying-sheep

OK the thing is linter-rust shows language-rust as dependency. Yeah and we don't need grammar this is completely true, but we have contributed to original grammar by adding some fields which is not in language-rust. https://github.com/AtomLinter/linter-rust/blob/master/package.json

So there are two options for that:

  • Use our own grammar - fork linter-rust and modify it for not using language-rust as package-dep
  • Use default grammar supplied by language-rust and remove default grammar in grammars. (In that case we couldn't update grammars by ourselves)

Your choice, your style.

vertexclique avatar May 02 '16 15:05 vertexclique

@colin-kiegel I couldn't understand what you mean by

you might want to combine this package with X, but you won't need Y

and redundant and complementary part. Redundant part is probably grammar part and complementary part is rest of it. Because if I exclude linter there will be no linter as you can think of.

vertexclique avatar May 02 '16 15:05 vertexclique

in the first comment: language-rust, terminal-plus, build-cargo are redundant; linter-rust is complementary

flying-sheep avatar May 02 '16 15:05 flying-sheep

Isn't it possible to contribute the grammar changes to language-rust upstream?

If that works out, tokamak could define language-rust as a dependency. Adding linter-rust wouldn't do any harm then.

colin-kiegel avatar May 02 '16 16:05 colin-kiegel

huh? how does it do harm now?

flying-sheep avatar May 02 '16 18:05 flying-sheep

sorry for the bad choice of words: Adding linter-rust wouldn't install any redundant dependencies then.

Better? :-)

colin-kiegel avatar May 02 '16 18:05 colin-kiegel

Long time no see! Sorry for that. I will update repo wiki with this information too. Thanks for feedback.

vertexclique avatar Mar 02 '17 19:03 vertexclique