vertx-web icon indicating copy to clipboard operation
vertx-web copied to clipboard

Fixed docs of vertx-web

Open ShivamPansuriya opened this issue 1 year ago • 4 comments

Changes in vertx-web/src/main/asciidoc/index.adoc @line-250,251

Motivation: There was a contradictory statement in vertx-web docs at #routing-by-exact-path.

Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

ShivamPansuriya avatar Apr 15 '24 07:04 ShivamPansuriya

@pmlopes can you double check this ? I am not sure

vietj avatar Apr 15 '24 08:04 vietj

What is required for me to get necessary legal agreements? @vietj @pmlopes

ShivamPansuriya avatar Apr 15 '24 09:04 ShivamPansuriya

What is required for me to get necessary legal agreements? @vietj @pmlopes

You must sign the Eclipse Contributor Agreement and invoke git commit with -s (signoff), assuming git config user.email and author.email are set to the email address provided when signing the contributor agreement.

tsegismont avatar Apr 15 '24 10:04 tsegismont

What is required for me to get necessary legal agreements? @vietj @pmlopes

You must sign the Eclipse Contributor Agreement and invoke git commit with -s (signoff), assuming git config user.email and author.email are set to the email address provided when signing the contributor agreement.

thanks for the help. it worked for me.

ShivamPansuriya avatar Apr 15 '24 11:04 ShivamPansuriya