vertx-web
vertx-web copied to clipboard
`WebClient.close()` does not return a `Future` or wait for resources to be released
Version
4.3.3~
Context
Call to WebClient.close() does not wait for resources to be released.
Method signature was changed so that it returns a Future<Void> here https://github.com/vert-x3/vertx-web/pull/2197
But later was reverted here https://github.com/vert-x3/vertx-web/commit/8dda3dec91648eddae01455b8a94cc1c0e25c864
I'd expect .close() to either return the Future<Void>, or (less ideally) block until the future finishes before returning.
Do you have a reproducer?
https://github.com/vert-x3/vertx-web/pull/2197#issuecomment-1150703458 https://github.com/vert-x3/vertx-web/commit/8dda3dec91648eddae01455b8a94cc1c0e25c864
Steps to reproduce
N/A
Extra
N/A
@vietj can you give some context about why the futurization change was reverted?
I think because it was a breaking change, but well
@tsegismont @vietj so is there any plan to change it again to return the future?
yes I think we should