vertx-web icon indicating copy to clipboard operation
vertx-web copied to clipboard

`WebClient.close()` does not return a `Future` or wait for resources to be released

Open mcanalesmayo opened this issue 1 year ago • 4 comments

Version

4.3.3~

Context

Call to WebClient.close() does not wait for resources to be released. Method signature was changed so that it returns a Future<Void> here https://github.com/vert-x3/vertx-web/pull/2197 But later was reverted here https://github.com/vert-x3/vertx-web/commit/8dda3dec91648eddae01455b8a94cc1c0e25c864 I'd expect .close() to either return the Future<Void>, or (less ideally) block until the future finishes before returning.

Do you have a reproducer?

https://github.com/vert-x3/vertx-web/pull/2197#issuecomment-1150703458 https://github.com/vert-x3/vertx-web/commit/8dda3dec91648eddae01455b8a94cc1c0e25c864

Steps to reproduce

N/A

Extra

N/A

mcanalesmayo avatar Feb 26 '24 00:02 mcanalesmayo

@vietj can you give some context about why the futurization change was reverted?

tsegismont avatar Mar 07 '24 17:03 tsegismont

I think because it was a breaking change, but well

vietj avatar Mar 08 '24 13:03 vietj

@tsegismont @vietj so is there any plan to change it again to return the future?

mcanalesmayo avatar Apr 02 '24 05:04 mcanalesmayo

yes I think we should

vietj avatar Apr 02 '24 06:04 vietj