vertx-stomp icon indicating copy to clipboard operation
vertx-stomp copied to clipboard

Why do not expose NetSocket in StompServerTCPConnectionImpl.java

Open eternalirons opened this issue 1 year ago • 2 comments

As the title suggests, why do not expose NetSocket in StompServerTCPConnectionImpl.java, I would like to obtain NetSocket at server side to get localAddress and remoteAddress, but no api expose NetSocket.

eternalirons avatar Aug 16 '23 15:08 eternalirons

Instead of exposing a underlying socket, we could have expose the addresses like we do in HttpConnection:

https://github.com/eclipse-vertx/vert.x/blob/c252928ced746429aa00544b8c2260f30e16bc34/src/main/java/io/vertx/core/http/HttpConnection.java#L224-L246

Would you like to contribute this?

tsegismont avatar Aug 22 '23 09:08 tsegismont

Okay, I'd love to

eternalirons avatar Oct 08 '23 09:10 eternalirons