vertx-starter icon indicating copy to clipboard operation
vertx-starter copied to clipboard

not open jdbc common neither postgres

Open seduardo opened this issue 5 years ago • 4 comments

Context

when select jdbc client jdbc common is not add in pom n and jdbc for mysql or postgres not show in list.

Steps to reproduce

  1. type jdbc in dependences input
  2. generate package
  3. open pom.xml

Extra

  • Anything that can be relevant

seduardo avatar May 17 '19 20:05 seduardo

@seduardo if you select the vertx-jdbc-client dependency, the generated project will transitively depend on vertx-sql-common, so it's not necessary to explicitly include it.

As for Postgres / MySQL drivers, I need some time to give it some thought, but it doesn't sound like a bad idea.

wdyt @danielpetisme @vietj ?

tsegismont avatar May 20 '19 09:05 tsegismont

Sorry for this delayed answer.

IMHO, adding automatically the drivers is a good idea (for the record, we can' distribute Oracle drivers). My main concern is the UX to propose the target database when you have selected vertx-jdbc-client

danielpetisme avatar Jul 25 '19 18:07 danielpetisme

@seduardo would you like to contribute this?

tsegismont avatar Jul 29 '19 16:07 tsegismont

@tsegismont yes I would like. Let me verify the code where I can help.

seduardo avatar Jul 30 '19 00:07 seduardo