vertx-service-discovery icon indicating copy to clipboard operation
vertx-service-discovery copied to clipboard

Published 20 hours ago • verified publisher icon vert-x3

AuthProvider service type

Open Cafeinoman opened this issue 8 years ago • 4 comments

Is it planned to add a type to be able to discover AuthProvider service. It will be useful for a centralized auth in microservice architecture... If you are interested, but not have time, I can work on this...

Cafeinoman avatar Jun 10 '16 09:06 Cafeinoman

👍

I like the idea. It was not planned, but definitely something we can add. Notice that service types are pluggable, so we can implement it in a separate project (or module under this project).

cescoffier avatar Jun 16 '16 06:06 cescoffier

@Cafeinoman just a question, what do you call AuthProvider, is it https://github.com/vert-x3/vertx-auth/blob/master/vertx-auth-common/src/main/java/io/vertx/ext/auth/AuthProvider.java ?

cescoffier avatar Jul 19 '16 06:07 cescoffier

Yes, that's it. I begin to work on a (very) simple implementation couple weeks ago, but got a lot work. Missing a lot of test at this time. You can find it on my repo.

Cafeinoman avatar Jul 19 '16 09:07 Cafeinoman

Just had a look. It looks good to me. Yes need more tests (especially polyglot test to be sure it's usable from groovy, js and ruby).

cescoffier avatar Jul 19 '16 14:07 cescoffier