vertx-rabbitmq-client icon indicating copy to clipboard operation
vertx-rabbitmq-client copied to clipboard

RabbitMQClient#restartConnect does not fail promise on retries configured to zero

Open damsgaard opened this issue 2 years ago • 2 comments

Version

4.3.1

Context

While reading the source code.

Do you have a reproducer?

The handler is not invoked in case of configuration of retries set to zero.

https://github.com/vert-x3/vertx-rabbitmq-client/blob/master/src/main/java/io/vertx/rabbitmq/impl/RabbitMQClientImpl.java#L222-L224

damsgaard avatar Jun 10 '22 08:06 damsgaard

Pull request https://github.com/vert-x3/vertx-rabbitmq-client/pull/158

damsgaard avatar Jun 10 '22 08:06 damsgaard

Merged.

Yaytay avatar Dec 20 '22 13:12 Yaytay