vertx-rabbitmq-client icon indicating copy to clipboard operation
vertx-rabbitmq-client copied to clipboard

Published 20 hours ago • verified publisher icon vert-x3

#145

Open Yaytay opened this issue 2 years ago • 1 comments

Motivation:

Remove @GenIgnore from addConnectionEstablishedCallback

Yaytay avatar Mar 18 '22 07:03 Yaytay

Hi @vietj,

Please can you take a look at this, is it OK to remove the @GenIgnore from addConnectionEstablishedCallback? The aim is to make it available to the Rx users. I'm not getting any errors, but I'm not sure that's a good indication in this case :)

If this isn't OK, is there a way to provide a Rx-compatible method that lets the caller register a method that completes asynchronously? Either returning a Future or taking in a Handler<AsyncResult> would be fine.

Note that the connectionEstablishCallback is called multiple times independently, which prevents some options.

Thanks.

Yaytay avatar Mar 18 '22 07:03 Yaytay