vertx-mqtt icon indicating copy to clipboard operation
vertx-mqtt copied to clipboard

Unused client options manipulation

Open ctron opened this issue 3 years ago • 0 comments

In the constructor of the MQTT client, it looks like some changes in the past have changed the originally intended behavior:

https://github.com/vert-x3/vertx-mqtt/blob/9a91ad811c4e9fbe47306fc2666f9bc4bc8ec33c/src/main/java/io/vertx/mqtt/impl/MqttClientImpl.java#L156-L165

From what I see, the netClientOptions gets copied, manipulated, but then not used at all.

ctron avatar Jun 09 '21 09:06 ctron