vertx-lang-kotlin icon indicating copy to clipboard operation
vertx-lang-kotlin copied to clipboard

Add some possibly useful code ported from https://github.com/huanshankeji/kotlin-common/tree/main/vertx

Open ShreckYe opened this issue 2 years ago • 11 comments

Motivation:

Hi, Vert.x Maintainers. We have been developing our projects in Kotlin with the Vert.x toolkit as the core of the backend. It's been quite smooth and this project provides a lot of useful extensions in Kotlin. During our development, we came up with a few more common extensions in our shared code repository, which we thought could be ported back to this project and made universally available.

We have tried to pick the less opinionated code from our common project in this PR so it's generally useful to most developers using Vert.x in Kotlin. If there is any code that is not appropriate to be added back to this repository, just feel free to remove it or make further changes as it suits your needs. Or if there is none to be added, just close this PR.

Thank you.

ShreckYe avatar Jun 08 '22 13:06 ShreckYe

can you use vertx-unit instead of vertx-junit5 for the tests for the sake of consistency ?

vietj avatar Jun 09 '22 05:06 vietj

OK, I will try to adapt them.

ShreckYe avatar Jun 09 '22 07:06 ShreckYe

@vietj Hi Julien. It's done. Please review.

ShreckYe avatar Jun 10 '22 13:06 ShreckYe

I pinged kotlin users on our discord to give eventually feedback on the PR

vietj avatar Jun 13 '22 09:06 vietj

There's some pretty neat additions proposed here that should help reduce boilerplate in most kotlin projects 👍

wowselim avatar Jun 13 '22 12:06 wowselim

Some updates with the documentation and code samples how to use the proposed new vertx kotlin extensions would be really helpful

jojopad avatar Jun 14 '22 03:06 jojopad

There's some pretty neat additions proposed here that should help reduce boilerplate in most kotlin projects +1

Thank you.

ShreckYe avatar Jun 14 '22 08:06 ShreckYe

I don't fully understand why the CI tests failed. Is it because that the "kotlin" source set in "vertx-lang-kotlin" is overriden by generated code?

ShreckYe avatar Jun 15 '22 14:06 ShreckYe

do we have consensus on this PR ?

vietj avatar Jun 16 '22 13:06 vietj

I don't know what is wrong with tests not passing, have you tried to build locally ?

vietj avatar Jun 22 '22 12:06 vietj

The Maven test phases pass locally. I moved Tuple.kt to the java source directory. Maybe this will work.

ShreckYe avatar Jun 22 '22 16:06 ShreckYe

Superseded by https://github.com/vert-x3/vertx-lang-kotlin/pull/253

tsegismont avatar Oct 24 '23 16:10 tsegismont