vertx-lang-kotlin icon indicating copy to clipboard operation
vertx-lang-kotlin copied to clipboard

Router DSL

Open Tim-Britton opened this issue 5 years ago • 4 comments

Hello All,

This pull request includes the Router DSL that I am working on. See #91

Any feedback is welcome!

Tim

Tim-Britton avatar Aug 30 '19 15:08 Tim-Britton

@vietj As far as testing the DSL how would you like that to be done?

I would normally use mockk to perform the testing but I'm not sure if its okay to add a new dependency to the project.

Tim-Britton avatar Aug 30 '19 15:08 Tim-Britton

Directory src/main/kotlin will be removed by the clean task, https://github.com/vert-x3/vertx-lang-kotlin/blob/c208e3a0760156b8a4cffe681daa31d0127a6ee7/vertx-lang-kotlin/pom.xml#L808-L817

So it is recommended to move the code to the src/main/java directory.

okou19900722 avatar Aug 31 '19 08:08 okou19900722

Directory src/main/kotlin will be removed by the clean task,

https://github.com/vert-x3/vertx-lang-kotlin/blob/c208e3a0760156b8a4cffe681daa31d0127a6ee7/vertx-lang-kotlin/pom.xml#L808-L817

So it is recommended to move the code to the src/main/java directory. @okou19900722

Maybe I'm not understanding but all the source files for this project are in src/man/kotlin am I messing something?

I've included what I'm seeing in intellij below:

image

Tim-Britton avatar Sep 03 '19 16:09 Tim-Britton

@Tim-Britton have you check the src/main/java yet? the extension function is generated to src/main/kotlin by vertx-codegen, so sometimes, If you execute mvn clean, directory src/main/kotlin will be removed

okou19900722 avatar Sep 04 '19 00:09 okou19900722

Superseded by #253

tsegismont avatar Oct 24 '23 16:10 tsegismont