vertx-examples icon indicating copy to clipboard operation
vertx-examples copied to clipboard

Improving vertx-heroku example

Open Tobias-Doerner opened this issue 5 years ago • 2 comments

The current vertx-heroku example is not compiling with Java 10. sun.misc.BASE64Encoder is missing updating the heroku-maven-plugin to the current version fixes that issue. I also would like to propose to use the vertx config retriever for fetching the system properties and the config vars defined in heroku's application settings.

Tobias-Doerner avatar Mar 12 '19 22:03 Tobias-Doerner

what is using sun.misc.BASE64Encoder ?

vietj avatar Mar 13 '19 08:03 vietj

heroku-maven-plugin version 0.5.6 is using sun.misc.BASE64Encoder, look here https://github.com/heroku/heroku-maven-plugin/blob/heroku-sdk-parent-0.5.6/heroku-deploy/src/main/java/com/heroku/sdk/deploy/Deployer.java

Tobias-Doerner avatar Mar 13 '19 09:03 Tobias-Doerner