vertx-circuit-breaker icon indicating copy to clipboard operation
vertx-circuit-breaker copied to clipboard

Published 20 hours ago • verified publisher icon vert-x3

Should one succeed command in circuit breaker, reset its previous failed results count?

Open EhsanSharifian opened this issue 3 years ago • 0 comments

After executing command, if the result succeeds, rollingCounter resets. I think this should be done just when the state is HALF_OPEN not CLOSED. Because every succeeding result clears previous failed counts in rollingCounter configured time window.

https://github.com/vert-x3/vertx-circuit-breaker/blob/d3e24630df8030aed21cb099c0dd06c840c38a19/src/main/java/io/vertx/circuitbreaker/impl/CircuitBreakerImpl.java#L231

EhsanSharifian avatar Nov 24 '21 13:11 EhsanSharifian