verso icon indicating copy to clipboard operation
verso copied to clipboard

Allow disable pinch zoom from cli

Open Legend-Master opened this issue 1 year ago • 5 comments

Enable touch support and allow disable pinch zoom from command line flag

Legend-Master avatar Nov 15 '24 08:11 Legend-Master

What's the motivation to disable pinch zoom as a configuration?

wusyong avatar Nov 18 '24 02:11 wusyong

This allows you to use your own pinch zoom handlings, for example https://figma.com and https://squoosh.app, I don't think we have preventDefault on touch events implemented currently, so this is a work around for now, also some people just want to make their web app (webview app) feel like a native app with all those web features disabled (personally I'm not a fan of it but there're people want that)

Legend-Master avatar Nov 18 '24 03:11 Legend-Master

It should implement preventDefault on touch events to Servo directly. I think we could explore other CLI options that could be more crucial.

wusyong avatar Nov 18 '24 03:11 wusyong

Sure we can, but I still want to argue that attaching non passive touch event listeners hurt performance

Legend-Master avatar Nov 18 '24 03:11 Legend-Master