mediasoup icon indicating copy to clipboard operation
mediasoup copied to clipboard

Test usrsctp with usrsctp_get_timeout()

Open ibc opened this issue 1 year ago • 2 comments

Details

  • Related task: https://github.com/versatica/mediasoup/issues/1011. Note that usrsctp author never cared about the existing PR so we are on our own.
  • So I've forked usrctp, added the usrsctp_get_timeout() feature and released version 0.9.6.0: https://github.com/versatica/usrsctp/pull/1
  • And I've made usrsctp.wrap point to it.

Notes

  • It would be great to have a way to pass sctp_debug=true when building usrsctp Meson subproject so it defines SCTP_DEBUG (needed in DepUsrSCTP.cpp to show SCTP debug). An manual alternative is to edit meson.build of usrsctp and add it unconditionally.
  • I'm calling HandleUsrSctpTimers() everytime the timer fires (of course), also in onSendSctpData callback and also when SCTP data is received (in SctpAssociation::ProcessSctpData(). Not sure if correct.
  • Extra MS_DUMP() added for debugging. Must be removed.
  • This PR should not be merged until super tested and NOT before this issue is solved: https://github.com/versatica/mediasoup/issues/1352
  • Most consider this: https://github.com/versatica/mediasoup/pull/1353#issuecomment-1983808781

ibc avatar Mar 05 '24 12:03 ibc

Will this PR merge to main ?

Lynnworld avatar Nov 15 '24 08:11 Lynnworld

Will this PR merge to main ?

Read the Notes above please. It cannot be merged.

ibc avatar Nov 15 '24 08:11 ibc