libmediasoupclient icon indicating copy to clipboard operation
libmediasoupclient copied to clipboard

Missing iceServers / iceTransportPolicy parameters when creating transport

Open fedulvtubudul opened this issue 2 years ago • 2 comments

TypeScript version of mediasoup client has iceServers and iceTransportPolicy parameters when calling createSendTransport method on Device entity: method declaration. C++ implementation of the libmediasoupclient does not have these parameters: method declaration.

Previously I've used UpdateIceServers method of the Transport entity and added UpdateIceTransportType method in our fork to set these parameters. But I guess it will be nice to have more consistent APIs between TS and C++ implementations, so I suggest adding missing parameters to Transport constructor. I was also motivated to open this issue by another one in our Swift wrapper for libmediasoupclient that suggested same way to set iceServers in TS and Swift.

I'll try to implement it myself and make a PR, but please say if I'm moving the right direction.

fedulvtubudul avatar Aug 01 '23 04:08 fedulvtubudul

libmediasoup and mediasop-client should be in sync, being mediasoup-client the original implementation, so yes. That's a right move.

But please, check the commit where it was implemented in TS and implement it accordingly in libmediasoupclient.

jmillan avatar Aug 01 '23 08:08 jmillan

While there are no iceServers and iceTransportPolicy parameters declared explicitly in the C++ library (and thats what confused me in the first place). Still looks like their values can be passed via peerConnectionOptions.config. So maybe we just need to add some explanation to the corresponding documentation paragraph.

fedulvtubudul avatar Aug 02 '23 13:08 fedulvtubudul