neo4j-rest-client icon indicating copy to clipboard operation
neo4j-rest-client copied to clipboard

Cache option doesn't appear to do anything

Open jmacarthur opened this issue 8 years ago • 1 comments

I tried turning options.CACHE on, but it didn't appear to have any effect. I dug into cachecontrol, and from what I can tell, it won't cache anything unless the response has a Cache-Control header and either a nonzero max-age or an "Expires" header. neo4j (3.0.1) doesn't send either of these, so I don't think it will ever cache a response.

I can't think of any way to fix this in this project, so I've modified my copy of cachecontrol so it caches things without the headers. It might be worth removing the section on caching from the documentation though. If you agree I can submit a PR.

jmacarthur avatar Jul 07 '16 13:07 jmacarthur

It makes sense. Please, send the PM if you like.

This project has not catch up with the new version of Neo4j 3.x, and unfortunately I am not sure if it will ever do.

Cheers.

versae avatar Jul 11 '16 21:07 versae