No JIRA. Align install/upgrade logic.

Open michael-cico opened this issue 2 years ago • 1 comments

Description

Consolidate the HelmComponent Upgrade and Install methods. Largely, these methods do the same thing with the exception that during upgrade, we get the existing values for an installed release. Both use helm upgrade --install under the covers.

Consolidating them around the same impl should limit the potential for bugs due to different logic between the upgrade and install paths, until we can do more consolidation there.

Change details:

Refactor Upgrade and Install calls to share the same logic
If the helm release exists, build the existing values overrides file (upgrade existing install case)
Remove remaining obsolete HelmComponent func callback hooks
Update related components

Checklist

As the author of this PR, I have:

[x] Checked that I included or updated copyright and license notices in all files that I altered
[x] Added or updated unit tests for any new functions I added
[ ] Added or updated integration tests if appropriate
[ ] Added or updated acceptance tests if appropriate

Code reviewer, please confirm this PR:

[ ] Addressed the requirement and meets the acceptance criteria
[ ] Does not introduce unrelated or spurious changes
[ ] Does not introduce any unapproved dependency
[ ] Makes sense and it easy to understand, and/or difficult areas of code are clearly documented so that they can be understood