docker-vernemq icon indicating copy to clipboard operation
docker-vernemq copied to clipboard

openshift: improve compatibility

Open blazdivjak opened this issue 6 years ago • 6 comments

This pull request includes updates for Openshift compatibility.

Tested:

  • Openshift 3.11
  • Kubernetes v1.10.11

Includes:

  • update container image permissions and user handling
  • update helm chart deployment docs
  • add security context related docs to Helm chart values

Container images: https://hub.docker.com/r/blazdivjak/docker-vernemq

blazdivjak avatar Apr 12 '19 15:04 blazdivjak

@blazdivjak Sorry for the delay, but thanks for the contribution. To be honest we don't know a lot about Openshift, maybe others from the community could step in to review this. cc @drf @francois-travais @codeadict

dergraf avatar May 15 '19 17:05 dergraf

I like the changes you did. I did not use helm or the deployments but your changes to the Dockerfiles work perfectly and deploy on Openshift without root or any other extra-permissions. I will not add a review and leave this to the contributers mentioned above.

loldiges avatar Jun 25 '19 12:06 loldiges

Sorry for being late to the party. However, the changes are sound to me, but I wonder whether this has been tested outside OpenShift given the various permission changes (apparently shouldn't be an issue, but better safe than sorry). So thumbs up, especially if somebody tested this on standard k8s :)

drf avatar Jul 02 '19 09:07 drf

I did test it on k8s as well. Not extensively however.

blazdivjak avatar Sep 06 '19 07:09 blazdivjak

@greggiles thanks a lot for your testing and vote to merge this. @dergraf merge? @ertanden given your experience, could you give a comment on this?

ioolkos avatar Feb 18 '20 13:02 ioolkos

@ioolkos this looks good to me.

Maybe a small comment, instead of adding the new file uid_entrypoint, we could also put the content of it at the beginning of the start_vernemq script. It would simplify things I guess.

ertanden avatar Mar 02 '20 12:03 ertanden