magithub
magithub copied to clipboard
vermiculus
Gitlab support ?
First, thanks for this package ! Now that magithub no longer depends on HUB, can we consider a Gitlab support ? Using glab client ?
That would be a separate package (perhaps a magitlab) and would require a system by which to choose a backend (where the 'backends' would be the installable packages and each backend would depend on the common display code). If we go this route though, it'll be interesting to see how we can still take advantage of GitHub-specific features and API.
Could you link or produce a brief comparison of GitLab and GitHub? Does GitLab have labels? What's its concept of a PR look like? Etc.
I'll leave the issue open, but this is out-of-scope for now. I'll note that something along these lines is one of @tarsius's future visions.
Slightly off topic, but I intend to update glab.el, once the current changes to ghub.el are "complete". And I intend to do so by transplanting recent history and then doing some git filter-branch voodoo. There might however be a delay because I am traveling.
From Gitter:
matrixbot @Seylerius Aug 28 23:18 What are the odds of gitlab support happening at some point in the near future, or is there a similar project to achieve a "magitlab"-like effect?
matrixbot @jgkamat Aug 28 23:27 That would be awesome but it seems unlikely since it uses the github api. Maybe magithub could have multiple backends?
Sean Allred @vermiculus 07:26 This has come up in the past. The glab client needs to mature before I can entertain the idea. Recent updates to apiwrap.el make it more feasible than it used to be, but there are still many things that would have to change. One of the larger things is that we would need to come up with some lightweight method dispatch for the different structures of similar objects (eg issues) to have anything close to a maintainable codebase.
Hey @vermiculus, any advance on this? Now that Debian has moved to a Gitlab instance for all its VCS stuff (see here), it would be great if magitlab could become a real thing.
Thanks in advance.
I don't plan to add gitlab support right now, but am leaving the idea as an open enhancement. To be perfectly transparent, I'm more of the mind to help with the magit forge efforts to make the interface truly backend-agnostic. That may mean some pieces (like CI status) are split out into separate packages, but it's better in the long run, I think.
It's uncertain when this will take place, however, but I hope to have a plan in place by early next year.
you mean https://github.com/magit/forge ? Sounds like a great approach... instead of retrofitting support for one of those, it seems much better to start with a generic/modular approach... :)
