magithub icon indicating copy to clipboard operation
magithub copied to clipboard

"There is no thing at point that could be edited" when trying to edit an issue

Open DrWaleedAYousef opened this issue 6 years ago • 11 comments

When "enter" an issue, then try to edit it (not commenting) this message is given in the mini-buffer: "There is no thing at point that could be edited"

DrWaleedAYousef avatar Aug 31 '18 13:08 DrWaleedAYousef

This is not yet supported.

vermiculus avatar Sep 07 '18 00:09 vermiculus

So you mean I only can create a new issue from magithub but cannot edit it; right?

DrWaleedAYousef avatar Sep 07 '18 09:09 DrWaleedAYousef

As of today, yes. This could change in the future provided I find the time to implement it (or some brave soul submits a PR).

vermiculus avatar Sep 07 '18 16:09 vermiculus

Thanks so much

DrWaleedAYousef avatar Sep 08 '18 14:09 DrWaleedAYousef

Leaving open as an enhancement.

vermiculus avatar Sep 08 '18 14:09 vermiculus

Any chance we can change the message in the meantime?

I too was scratching my head about "nothing at point that could be edited" when trying to edit an issue :(

ccressent avatar Sep 12 '18 00:09 ccressent

It's a standard message provided by magithub-edit-thing. I'd be fine with changing the message, but it would need to make sense for anything you might want to edit.

vermiculus avatar Sep 14 '18 14:09 vermiculus

I'm a beginner elisper, but it looks like magithub-edit-thing is purely and simply not implemented (source here)? What about changing the error to something like "This operation is not supported yet."?

I imagine that down the road, magithub-edit-thing is going to look at what's at point and call different functions accordingly, ie: magithub-comment-edit if it's a comment, ...?

ccressent avatar Sep 14 '18 21:09 ccressent

Not quite. In fact, magithub-edit-thing is remapped to different functions in different keymaps.

vermiculus avatar Sep 14 '18 23:09 vermiculus

I see, now I understand better your dilemma with changing the message!

ccressent avatar Sep 14 '18 23:09 ccressent

https://github.com/vermiculus/magithub/pull/386 implements this issue

ibizaman avatar Nov 19 '18 04:11 ibizaman