magithub icon indicating copy to clipboard operation
magithub copied to clipboard

Sorting is not applied

Open vspinu opened this issue 6 years ago • 2 comments

AFAICS magithub-issue--sort is never called.

I have

(defun my-magithub-issue-sort-updated-ascending (a b)
  (time-less-p (date-to-time (alist-get 'updated_at a))
               (date-to-time (alist-get 'updated_at b))))

(setq magithub-issue-sort-function #'my-magithub-issue-sort-updated-ascending)

BTW, would be nice to have such a sort function as part of magithub itself. It's a common pattern. Even better, would be great to have toggling of the sorting type inside the status buffer. Would you like to have a separate issue for that?

vspinu avatar Jul 30 '18 12:07 vspinu

Regarding default sorts, there's an issue for that already. I'd like to realize some concept of issue 'views' that can be switched between, but sadly I've not had the time for this project as I once did.

vermiculus avatar Jul 30 '18 13:07 vermiculus

Here it is #124. Would be great indeed!

vspinu avatar Jul 31 '18 15:07 vspinu