magithub icon indicating copy to clipboard operation
magithub copied to clipboard

magithub-label-read-labels doesn't explain itself

Open gavinrogers opened this issue 7 years ago • 2 comments

https://github.com/vermiculus/magithub/blob/bc318ec9953b919195fbaa980b6873b6af7bed81/magithub-label.el#L50

As a user, I can't seem to figure out how to exit this loop.

  1. Could someone please tell me
  2. I'll create a PR with a prompt that documents how to "Continue" after you've selected what labels you wish.

gavinrogers avatar Jul 11 '18 18:07 gavinrogers

You need to provide a value of 'empty-string' to exit. Under Ivy, it's C-M-j.

https://github.com/vermiculus/magithub/blob/c2ba8025d96e60783672e4103c554e2cdeb3a19f/magithub-core.el#L811-L825

https://github.com/vermiculus/magithub/blob/c2ba8025d96e60783672e4103c554e2cdeb3a19f/magithub-core.el#L795-L809

It is in the documentation of the function, but I can see it being useful in the prompt. The only concern is wrapping.

vermiculus avatar Jul 11 '18 18:07 vermiculus

With helm it's C - <ENTER> for anyone else's benefit. I'll come around to a PR when I have time

gavinrogers avatar Jul 11 '18 22:07 gavinrogers