magithub icon indicating copy to clipboard operation
magithub copied to clipboard

Recent change to PR fork default doesn't play well w/ ivy

Open aaronjensen opened this issue 6 years ago • 2 comments

This commit defaults to my username as the fork: https://github.com/vermiculus/magithub/commit/2f2bb1cf08b742d49cd3a278f89baefa0a5a524c

That's ok if I have a fork, but if I don't, and I'm using ivy as my chooser I end up seeing no options. I have to erase my github username from the search to find origin.

aaronjensen avatar Jul 05 '18 21:07 aaronjensen

I use ivy as my primary completion system – my assumption is that your fork will be under your username. Is that not correct for you?

vermiculus avatar Sep 08 '18 15:09 vermiculus

If I have two remotes (when I wrote this originally the code to default to the only remote was not present) and neither of them is a fork, I do not have a remote named after my username, so defaulting to that doesn’t work properly.

I’m on my phone and haven’t tested this recently, but that was the problem.

aaronjensen avatar Sep 08 '18 15:09 aaronjensen